Did submarines always fire torpedoes while submerged?

No. Captains realized that submarines could attack on the surface at night, when they could hardly be seen. German U-boat captains had learned the same thing much earlier. Sonar won’t find a submarine on the surface because it is lost in all the noise. Radar was needed to find the boats on the surface at night, and the Japanese were slow to provide that equipment to escort ships.